Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: pin celery and fix default config #175

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

topless
Copy link
Member

@topless topless commented Nov 15, 2019

  • default for OAISERVER_QUERY_PARSER_FIELDS
  • pinned celery less than 4.3

@topless topless changed the title global: fixes for cookiecutter-instance global: pin celery and fix default config Nov 15, 2019
@topless topless added this to Backlog in Sprint Week 46-47 (2019) - V3.2 Release via automation Nov 15, 2019
@topless topless moved this from Backlog to Pending review in Sprint Week 46-47 (2019) - V3.2 Release Nov 15, 2019
@ntarocco ntarocco moved this from Pending review to Pending merge in Sprint Week 46-47 (2019) - V3.2 Release Nov 15, 2019
setup.py Outdated Show resolved Hide resolved
@kpsherva kpsherva moved this from Pending merge to In progress in Sprint Week 46-47 (2019) - V3.2 Release Nov 15, 2019
@ntarocco ntarocco moved this from In progress to Pending review in Sprint Week 46-47 (2019) - V3.2 Release Nov 15, 2019
@ntarocco
Copy link
Contributor

@topless I restarted 3 times but something is failing here... can you please try locally?

@ntarocco ntarocco changed the title global: pin celery and fix default config [BUILD FAILING] global: pin celery and fix default config Nov 17, 2019
@topless topless force-pushed the fix-default-config branch 8 times, most recently from 0bc3f6a to 2b2d9a0 Compare November 18, 2019 12:55
@roksys roksys self-assigned this Nov 18, 2019
@topless topless force-pushed the fix-default-config branch 2 times, most recently from 2bd83f2 to b2f8d65 Compare November 18, 2019 13:26
@kpsherva kpsherva self-assigned this Nov 18, 2019
- default for OAISERVER_QUERY_PARSER_FIELDS
- pinned celery less than 4.3
@ntarocco ntarocco changed the title [BUILD FAILING] global: pin celery and fix default config global: pin celery and fix default config Nov 18, 2019
setup.py Outdated
'Flask-CeleryExt>=0.3.0',
# Avoid version 4.3 it breaks the emails with datetime
# https://github.com/celery/celery/pull/5606
"celery>=4.2.1,<4.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topless To be removed?

@@ -8,6 +8,9 @@

addons:
postgresql: 9.4
apt:
packages:
- rabbitmq-server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topless @roksys this is the fix for the build.
See https://docs.travis-ci.com/user/database-setup/#rabbitmq

It was hanging doing flask index queue init here because it was waiting for rabbitmq.

@kpsherva kpsherva moved this from Pending review to In progress in Sprint Week 46-47 (2019) - V3.2 Release Nov 19, 2019
@kpsherva kpsherva moved this from In progress to Pending review in Sprint Week 46-47 (2019) - V3.2 Release Nov 19, 2019
@kpsherva kpsherva removed their assignment Nov 19, 2019
@kpsherva kpsherva moved this from Pending review to Pending merge in Sprint Week 46-47 (2019) - V3.2 Release Nov 19, 2019
@kpsherva kpsherva merged commit b9849c9 into inveniosoftware:master Nov 19, 2019
Sprint Week 46-47 (2019) - V3.2 Release automation moved this from Pending merge to Done Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants