Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: manage flask dependency centrally #183

Merged
merged 2 commits into from Mar 17, 2020
Merged

global: manage flask dependency centrally #183

merged 2 commits into from Mar 17, 2020

Conversation

kpsherva
Copy link
Contributor

@kpsherva kpsherva commented Mar 16, 2020 •
edited

@kpsherva kpsherva added this to Pending review in Sprint Week 10-11 (2020) - V3.3 Release via automation Mar 16, 2020
slint
slint approved these changes Mar 16, 2020
View reviewed changes
invenio_oaiserver/query.py Outdated
Comment on lines 60 to 61
if spec is None and search_pattern is None:
raise StopIteration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here this kind of change behaviour (i.e. if none of the variables exist normally this code would exit). You can replace raise StopIteration with a return statement here. See also https://www.juandebravo.com/2018/11/09/python-37-stop-iteration/

@kpsherva kpsherva force-pushed the update-deps branch 2 times, most recently from e8b42d1 to dfa4548 Compare March 16, 2020 16:33
@slint slint mentioned this pull request Mar 17, 2020
Closed
@kpsherva @slint
global: manage flask dependency centrally
1f6d8b2 
* drop support for python 2.7
* update travis.yml
@slint slint merged commit 5fcba05 into inveniosoftware:master Mar 17, 2020
Sprint Week 10-11 (2020) - V3.3 Release automation moved this from Pending review to Done Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slint slint slint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sprint Week 10-11 (2020) - V3.3 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

global: fix build failure
2 participants
@kpsherva @slint