dependencies: restrict max version of wtforms #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppanero
force-pushed
the
deps
branch
2 times, most recently
from
5d9b305
to
7090099
Compare
fenekku
reviewed
Jun 1, 2021
| 'invenio-i18n>=1.2.0', | ||
| 'invenio-theme>=1.3.4', | ||
| 'pyjwt>=1.5.0', | ||
| 'requests-oauthlib>=1.1.0,<1.2.0', | ||
| 'WTForms-Alchemy>=0.15.0', | ||
| 'WTForms>=2.0.0,<3.0.0', | ||
| ] |
There was a problem hiding this comment.
The invenio-db constraints also needs to be updated to: '>=1.0.9,<2.0.0' for mysql, postgresl, sqlite.
!
ntarocco
reviewed
Jun 2, 2021
| @@ -71,6 +71,19 @@ def init_app(app): | |||
| SQLALCHEMY_TRACK_MODIFICATIONS=True, | |||
| TESTING=True, | |||
| WTF_CSRF_ENABLED=False, | |||
| APP_THEME="semantic-ui", | |||
There was a problem hiding this comment.
This should not be needed, we have fixed it in pytest-invenio:
inveniosoftware/pytest-invenio@15c15bd
can you try to bump the pytest-invenio>=1.4.2?
There was a problem hiding this comment.
Doesn't seem to work, bumped here jrcastro2#1, but not working.
There was a problem hiding this comment.
As discussed, the fixtures are not using pytest-invenio ones. It requires too many changes at the moment.
added 2 commits
June 2, 2021 16:52
* dependencies: bump invenio-base (flask and werkzeug limit) * dependencies: bump invenio-db * Add missing config variables
ntarocco
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #228
includes release commit and changelog
CI has been broken for the last 5 months... installation takes forever locally (is been resolving for the las 40')