Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext: fix scopes loading #36

Closed

Conversation

hachreak
Copy link
Member

Signed-off-by: Leonardo Rossi leonardo.r@cern.ch

Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.798% when pulling d66b202 on hachreak:fix_register_scopes into 6be9088 on inveniosoftware:master.

@@ -91,7 +91,7 @@ def register_scope(self, scope):
def load_entry_point_group(self, entry_point_group):
"""Load actions from an entry point group."""
for ep in pkg_resources.iter_entry_points(group=entry_point_group):
self.register_scope(ep.load())
self.register_scope(ep.load()())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which problem does this PR fix?

@hachreak
Copy link
Member Author

hachreak commented Apr 22, 2016

see inveniosoftware/invenio-deposit#40
ep.load() returns me the class, not the object.
Because the register_scope() waits an object.

@jirikuncar
Copy link
Member

The problem is in Invenio-Deposit which should create instances of Scope (see https://github.com/inveniosoftware/invenio-deposit/pull/40/files#r60872932 and https://github.com/inveniosoftware/invenio-deposit/pull/40/files#r60873054).

@jirikuncar jirikuncar closed this Apr 25, 2016
@jirikuncar jirikuncar added this to the v1.0.0 milestone Apr 25, 2016
@jirikuncar jirikuncar self-assigned this Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants