Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: check-up and clean #26

Closed
2 tasks done
lnielsen opened this issue Dec 8, 2015 · 0 comments · Fixed by #32
Closed
2 tasks done

global: check-up and clean #26

lnielsen opened this issue Dec 8, 2015 · 0 comments · Fixed by #32
Assignees
@JavierDelgadoFernandez
Labels
Type: enhancement
Milestone
v1.0.0

Comments

@lnielsen
Copy link
Member

lnielsen commented Dec 8, 2015

  • Check that settings nicely integrate with accounts settings (Linked accounts)
  • Add template macros so that login buttons for each service appears the login page.
@lnielsen lnielsen added this to the v1.0.0 milestone Dec 8, 2015
JavierDelgadoFernandez added a commit to JavierDelgadoFernandez/invenio-oauthclient that referenced this issue Dec 16, 2015
@JavierDelgadoFernandez
templates: addition of OAuth login buttons macro
42658fd 
* Adds a macro to generate the links to connect wit the installed
  OAuth services.

* Adds a login_user.html template with the form showing the
  OAuth services to login and the fields to a regular login.
  (closes inveniosoftware#26)

Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
JavierDelgadoFernandez added a commit to JavierDelgadoFernandez/invenio-oauthclient that referenced this issue Dec 16, 2015
@JavierDelgadoFernandez
templates: addition of OAuth login buttons macro
ec2d33d 
* Adds a macro to generate the links to connect with the installed
  OAuth services.

* Adds a login_user.html template with the form showing the
  OAuth services to login and the fields to a regular login.
  (closes inveniosoftware#26)

Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
Closed
JavierDelgadoFernandez added a commit to JavierDelgadoFernandez/invenio-oauthclient that referenced this issue Dec 17, 2015
@JavierDelgadoFernandez @jirikuncar
templates: addition of OAuth login buttons macro
b82235c 
* Adds a macro to generate the links to connect with the installed
  OAuth services.

* Adds a login_user.html template with the form showing the
  OAuth services to login and the fields to a regular login.
  (closes inveniosoftware#26)

Co-Authored-By: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
jirikuncar added a commit to jirikuncar/invenio-oauthclient that referenced this issue Dec 17, 2015
@JavierDelgadoFernandez @jirikuncar
templates: addition of OAuth login buttons macro
05315cf 
* Adds a macro to generate the links to connect with the installed
  OAuth services.

* Adds a login_user.html template with the form showing the
  OAuth services to login and the fields to a regular login.
  (closes inveniosoftware#26)

Co-Authored-By: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
@jirikuncar jirikuncar mentioned this issue Dec 17, 2015
Merged
jirikuncar added a commit to jirikuncar/invenio-oauthclient that referenced this issue Dec 18, 2015
@JavierDelgadoFernandez @jirikuncar
templates: addition of OAuth login buttons macro
96745e8 
* Adds a macro to generate the links to connect with the installed
  OAuth services.

* Adds a login_user.html template with the form showing the
  OAuth services to login with and the fields to a regular login.
  It overrides template specified in `OAUTHCLIENT_TEMPLATE_KEY`
  by one specified in `OAUTHCLIENT_USER_LOGIN_TEMPLATE`.
  (closes inveniosoftware#26)

Co-authored-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
jirikuncar added a commit to jirikuncar/invenio-oauthclient that referenced this issue Dec 18, 2015
@JavierDelgadoFernandez @jirikuncar
templates: addition of OAuth login buttons macro
de1682a 
* Adds a macro to generate the links to connect with the installed
  OAuth services.

* Adds a login_user.html template with the form showing the
  OAuth services to login with and the fields to a regular login.
  It overrides template specified in `OAUTHCLIENT_TEMPLATE_KEY`
  by one specified in `OAUTHCLIENT_USER_LOGIN_TEMPLATE`.
  (closes inveniosoftware#26)

Co-authored-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
oguzdemirbasci pushed a commit to oguzdemirbasci/invenio-oauthclient that referenced this issue Jan 8, 2021
@JavierDelgadoFernandez @jirikuncar @oguzdemirbasci
templates: addition of OAuth login buttons macro
eac1997 
* Adds a macro to generate the links to connect with the installed
  OAuth services.

* Adds a login_user.html template with the form showing the
  OAuth services to login with and the fields to a regular login.
  It overrides template specified in `OAUTHCLIENT_TEMPLATE_KEY`
  by one specified in `OAUTHCLIENT_USER_LOGIN_TEMPLATE`.
  (closes inveniosoftware#26)

Co-authored-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JavierDelgadoFernandez JavierDelgadoFernandez

Labels
Type: enhancement
Projects
None yet
Milestone
v1.0.0
2 participants
@lnielsen @JavierDelgadoFernandez