global: move oauthclient into new module structure #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachreak
force-pushed
the
cookiecutter_template
branch
2 times, most recently
from
fec53a3
to
8c3e07c
Compare
hachreak
force-pushed
the
cookiecutter_template
branch
7 times, most recently
from
3b8f2aa
to
32b8d65
Compare
|
ping @lnielsen |
|
|
||
| def __init__(self, app=None): | ||
| """Extension initialization.""" | ||
| _('A translation string') |
hachreak
force-pushed
the
cookiecutter_template
branch
3 times, most recently
from
ff9a30f
to
cd644f4
Compare
hachreak
force-pushed
the
cookiecutter_template
branch
3 times, most recently
from
8f484a7
to
3b3d4e2
Compare
| InvenioAccounts(app) | ||
| FlaskOAuth(app) | ||
| InvenioOAuthClient(app) | ||
|
|
hachreak
force-pushed
the
cookiecutter_template
branch
3 times, most recently
from
75d2199
to
686ca6a
Compare
| @@ -104,28 +131,35 @@ def run_tests(self): | |||
| version=version, | |||
| description=__doc__, | |||
| long_description=readme + '\n\n' + history, | |||
| keywords='invenio oauth authentication', | |||
| keywords='invenio TODO', | |||
There was a problem hiding this comment.
keywords='invenio oauth authentication',
hachreak
force-pushed
the
cookiecutter_template
branch
7 times, most recently
from
8870626
to
f1f117f
Compare
| db.session.commit() | ||
| with db.session.begin_nested(): | ||
| self.access_token = token | ||
| self.secret = secret |
There was a problem hiding this comment.
add db.session.add(self) in case somebody uses the function directly after initializing the object
* INCOMPATIBLE Updates module structure accordly with Invenio 3. (addresses inveniosoftware#12) * Removes invenio-utils, invenio-ext, invenio-base, Flask-Registry dependencies. * Refactor forms to use Flask-Security instead of custom implementation. * Incorporates UserEXT table from invenio-accounts and renames it to UserIdentity. * NOTE Disables extra fields loading from orcid provider. Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
force-pushed
the
cookiecutter_template
branch
from
f1f117f
to
827be00
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.