-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Globus as an identity provider #158
Conversation
NickolausDS
commented
Jan 30, 2018
- Globus Login work for any provider Globus Auth supports
- Added tests, coverage of new code is 100%
- Added Sphinx docs
9316269
to
3f0362a
Compare
Thanks a lot for the contribution. We'll have to keep the contribution on hold for a bit because we're changing the license of Invenio from GPL to MIT. Unfortunately, discussion with our lawyers is taking longer than expected, and thus we cannot integrate code from non-CERN contributors until this has finished. I'm sorry about this. |
Thanks for the update, I hope the license transition goes smoothly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (with CERN institute) and works great!
(ping @lnielsen)
@NickolausDS we can merge this, though could you tell us what legal entity is the copyright holder for this code, so we can include it in the headers? Also, please check if the case is that since this code might have been written as part of an employment contract which grants your employer the copyright to all source code you write (keep in mind that this could also apply for code written outside of working hours), the copyright holder might be your employer. |
@slint, @NickolausDS did write this as part of his employment and the copyright holder is the University of Chicago. You can see an example of our copyright headers in some of our code. Do you need any more information or is that sufficient? Thanks |
6aba6fb
to
40c2c02
Compare
* Adds support for logging in with Globus for any provider that Globus Auth supports.
40c2c02
to
cc48dc8
Compare
@rpwagner @NickolausDS - I've rebased the PR and updated the copyright headers. Last thing before I press the merge button, could you please confirm that you license your PR under MIT License (since the old headers said GPL - which was probably just due to copy/paste)? |
@lnielsen Yes, confirming here to license this pull request under MIT. Thanks for switching that. |
Merged. Thanks a lot for the contribution, and apologies for taking so long to merge. |
No need for an apology, I know licensing can get complex and take time to sort out all the details. Thanks for picking this back up, your help was much appreciated! |