oauth: Create CERN OAuth blueprint to allow redirection to login.cern… #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Dec 6, 2018
invenio_oauthclient/contrib/cern.py
Outdated
| @cern_oauth_blueprint.route('/cern/logout') | ||
| def logout(): | ||
| """CERN logout view.""" | ||
| return redirect("https://login.cern.ch/adfs/ls/partiallogout.aspx", |
There was a problem hiding this comment.
I think it would be nice to have this url configurable... WDYT?
You can put it in REMOTE_APP config maybe.
There was a problem hiding this comment.
I also think the logout url should be in a config variable
kpsherva
approved these changes
Dec 10, 2018
ntarocco
approved these changes
Dec 10, 2018
ppanero
moved this from Pending review
to Pending merge
in Invenio Sprint Dec 3 - Dec 14 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180
In order to use it the blueprint should be added:
And the Flask Security config variable should be set up: