utils: fixes missing args from redirect target #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glignos
force-pushed
the
add_args_in_redirect
branch
3 times, most recently
from
435b1a1
to
5fa6965
Compare
Glignos
force-pushed
the
add_args_in_redirect
branch
from
5fa6965
to
60f1c3b
Compare
slint
approved these changes
Feb 26, 2019
ntarocco
approved these changes
Feb 26, 2019
| @@ -157,7 +157,11 @@ def get_safe_redirect_target(arg='next'): | |||
| if redirect_uri.host in allowed_hosts: | |||
| return target | |||
| elif redirect_uri.path: | |||
| return redirect_uri.path | |||
| return uricompose( | |||
There was a problem hiding this comment.
Nice this uricompose, I have learnt something! :)
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.