global: werkzeug compatibility patch #196
Conversation
kpsherva
added this to Pending review
in Sprint Week 10-11 (2020) - V3.3 Release
via automation
kpsherva
moved this from Pending review
to In progress
in Sprint Week 10-11 (2020) - V3.3 Release
| @@ -83,6 +82,9 @@ | |||
| from invenio_oauthclient.views.client import blueprint as blueprint_client | |||
| from invenio_oauthclient.views.settings import blueprint as blueprint_settings | |||
|
|
|||
| from invenio_oauthclient._compat import monkey_patch_werkzeug # noqa isort:skip | |||
There was a problem hiding this comment.
I think you forgot the monkeypatch call.
There was a problem hiding this comment.
the trick is that I actually don't have to call it, since it goes through __init__.py of the package and it is invoked there. You just need to make sure it is invoked, and this is what this line does
There was a problem hiding this comment.
But in the rest of the examples you call it, what is the difference?
There was a problem hiding this comment.
I agree with the explicit call to the function
kpsherva
force-pushed
the
update-deps
branch
7 times, most recently
from
1ee24dc
to
a75022c
Compare
kpsherva
moved this from In progress
to Pending review
in Sprint Week 10-11 (2020) - V3.3 Release
| @@ -83,6 +82,9 @@ | |||
| from invenio_oauthclient.views.client import blueprint as blueprint_client | |||
| from invenio_oauthclient.views.settings import blueprint as blueprint_settings | |||
|
|
|||
| from invenio_oauthclient._compat import monkey_patch_werkzeug # noqa isort:skip | |||
There was a problem hiding this comment.
I agree with the explicit call to the function
| 'invenio-userprofiles>=1.0.0', | ||
| 'requests-oauthlib>=0.6.2,<1.2.0', |
There was a problem hiding this comment.
Does this need to be both in install_requires and here?
There was a problem hiding this comment.
unfortunatelly yes, otherwise it is installing version more than 1.2 from travis
kpsherva
moved this from Pending review
to Pending merge
in Sprint Week 10-11 (2020) - V3.3 Release
* updates python dependencies * updates documentation links * cleans travis.yml
closes global: fix import error #194