Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: decode redirect target #204

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

carantunes
Copy link
Contributor

Fixes: #203

Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just out of curiosity can you post how the output was before the fix for the test case you added?

Also, do you need a release for this one? You can then also push a patch version commit, i.e. v1.2.1, like this one: aee0453

@carantunes
Copy link
Contributor Author

Previously
/oauth/authorize?redirect_uri=http%3A%2F%2F127.0.0.1%3A5100%2Fauthorized
was being transformed into
oauth/authorize?redirect_uri=http%253A%252F%252F127.0.0.1%253A5100%252Fauthorized

Should I commit the patch version commit into this PR as well?

@slint
Copy link
Member

slint commented Apr 17, 2020

Thanks for the example, indeed it's super weird that it got serialized like this...

Should I commit the patch version commit into this PR as well?

Yes, but put it in a separate commit with a release: v1.2.1 message (like the one I linked for v1.2.0).

@carantunes
Copy link
Contributor Author

Done @slint

@slint slint merged commit 80de602 into inveniosoftware:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on query params in redirect target
2 participants