global: add oauthclient rest workflow #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnielsen
reviewed
May 12, 2020
invenio_oauthclient/views/rest.py
Outdated
| @@ -0,0 +1,161 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
I think there's still a bit of work here between client.py and rest.py.
Same pattern repeats in all functions:
Closed
lnielsen
approved these changes
May 14, 2020
zzacharo
force-pushed
the
rest-api-refactor
branch
9 times, most recently
from
7e1d305
to
20dbf79
Compare
zzacharo
force-pushed
the
rest-api-refactor
branch
from
cd90bc6
to
9bbe51d
Compare
zzacharo
force-pushed
the
rest-api-refactor
branch
from
9bbe51d
to
83eee3b
Compare
Closed
ppanero
moved this from In progress
to Pending merge
in Sprint Week 19-20 - Invenio v3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the refactoring in a new PR so we can keep the alternative implementation.
Note: I haven't fixed the tests yet.