Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: add semantic ui #207

Merged
merged 1 commit into from
Jun 22, 2020
Merged

templates: add semantic ui #207

merged 1 commit into from
Jun 22, 2020

Conversation

KonstantinaStoikou
Copy link
Contributor

Closes #206

Selection_004
Selection_009

<div class="content">
{%- block signup_app_icon %}
{% if app_icon -%}
<i class="facebook icon large"></i>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facebook?

{% endmacro %}


{% macro form_errors(form) %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for @kprzerwa were you able how the errors are rendered?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't render form_errors because it is used only in the signup.html and to view that file I need to setup the Github authorization.

Copy link
Contributor

@kpsherva kpsherva May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not super fast to do, clue how to solve in:
inveniosoftware/invenio-accounts#325

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created dedicate issue: #209

{# -*- coding: utf-8 -*-

This file is part of Invenio.
Copyright (C) 2015-2018 CERN.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor, everywhere

Suggested change
Copyright (C) 2015-2018 CERN.
Copyright (C) 2015-2020 CERN.

{{ oauth_button(name, next=request.args.get('next')) }}
{% endfor %}
</div>
<h3 align="center">&mdash; OR &mdash;</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can use the Semantic UI divider here?

{% endmacro %}


{% macro form_errors(form) %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created dedicate issue: #209

@lnielsen lnielsen added this to In progress in InvenioRDM May Board via automation May 26, 2020
@lnielsen lnielsen self-assigned this May 26, 2020
@lnielsen lnielsen removed this from In progress in InvenioRDM May Board May 26, 2020
@cfgamboa
Copy link

Will it be possible to add a variable/flag similar to this SECURITY_REGISTERABLE, to disable local account sign in? It is not clear to me if this already exists but I think this will be useful as not everyone will use the local sign up. in the invenio.cfg file, SECURITY_LOCAL_USER_LOGIN=False--> will not show Email and Password forms in the login page

@zzacharo zzacharo merged commit e53f2e0 into inveniosoftware:master Jun 22, 2020
@KonstantinaStoikou KonstantinaStoikou deleted the semantic-ui branch December 11, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global: migrate templates/assets to Semantic-UI
6 participants