-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates: add semantic ui #207
templates: add semantic ui #207
Conversation
<div class="content"> | ||
{%- block signup_app_icon %} | ||
{% if app_icon -%} | ||
<i class="facebook icon large"></i> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
facebook?
{% endmacro %} | ||
|
||
|
||
{% macro form_errors(form) %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for @kprzerwa were you able how the errors are rendered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't render form_errors because it is used only in the signup.html
and to view that file I need to setup the Github authorization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not super fast to do, clue how to solve in:
inveniosoftware/invenio-accounts#325
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created dedicate issue: #209
{# -*- coding: utf-8 -*- | ||
|
||
This file is part of Invenio. | ||
Copyright (C) 2015-2018 CERN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor, everywhere
Copyright (C) 2015-2018 CERN. | |
Copyright (C) 2015-2020 CERN. |
{{ oauth_button(name, next=request.args.get('next')) }} | ||
{% endfor %} | ||
</div> | ||
<h3 align="center">— OR —</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can use the Semantic UI divider here?
{% endmacro %} | ||
|
||
|
||
{% macro form_errors(form) %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created dedicate issue: #209
Will it be possible to add a variable/flag similar to this SECURITY_REGISTERABLE, to disable local account sign in? It is not clear to me if this already exists but I think this will be useful as not everyone will use the local sign up. in the invenio.cfg file, SECURITY_LOCAL_USER_LOGIN=False--> will not show Email and Password forms in the login page |
Closes #206