Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handlers: export rest handlers #210

Merged
merged 2 commits into from
Jun 3, 2020
Merged

handlers: export rest handlers #210

merged 2 commits into from
Jun 3, 2020

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Jun 3, 2020 •
edited
Loading

Closes inveniosoftware/invenio-app-rdm#188

  • Ideal would be to rename ui exports (import as ....) but that would break compatibility with 1.3.0 release
  • How could a test for this be made? Sadly it fails only at run time but without a IdP this cannot be checked...

Import works:
Screenshot 2020-06-03 at 13 33 31

RDM needs this released

slint
slint approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add a release commit with it I guess if it's time :)

@ppanero
Copy link
Member Author

ppanero commented Jun 3, 2020

@slint done, check if the changelog seems correct, after is ready for release :)

@zzacharo zzacharo merged commit 42d2437 into inveniosoftware:master Jun 3, 2020
@ppanero ppanero deleted the handlers branch June 3, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slint slint slint approved these changes

@zzacharo zzacharo zzacharo approved these changes

@lnielsen lnielsen Awaiting requested review from lnielsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to initialize entry point: invenio_oauthclient which breaks mounting /api/
3 participants
@ppanero @slint @zzacharo