contrib: fix orcid configuration #211
Conversation
invenio_oauthclient/contrib/orcid.py
Outdated
| @@ -91,7 +91,7 @@ | |||
| 'show_login': 'true'}, | |||
| base_url='https://pub.orcid.org/v1.2/', | |||
| request_token_url=None, | |||
| access_token_url="https://api.orcid.org/oauth/token", | |||
| access_token_url="https://pub.orcid.org/oauth/token", | |||
There was a problem hiding this comment.
@jma did orcid change their access token URL? The old doesn't exist anymore?
There was a problem hiding this comment.
No, this is probably a copy/paste error. Look line 92. pub is for public and api is for members which is define latter in the file.
There was a problem hiding this comment.
This is the purpose of this PR.
There was a problem hiding this comment.
Sorry, I misread your message and thought you made a copy/paste error, not that the issue being fixed was a copy/paste error. Sorry for the misunderstanding 😅
Now I understand the issue :). We will just need to crosscheck the change with Zenodo.
There was a problem hiding this comment.
And apparently, it seems that we're all wrong :)
Not sure what version we're using but according to the article the {pub,api}.orcid.org endpoints are deprecated (in practice we are using them in Zenodo production though...).
There was a problem hiding this comment.
So, @slint we should change the access_token_url to https://orcid.org/oauth/token, right?
There was a problem hiding this comment.
@zzacharo I also misunderstood you comment, I apologise for this.
There was a problem hiding this comment.
Tested locally with access_token_url='https://orcid.org/oauth/token' and everything works as expected
* Adds error message when a remote server error occurs. Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Signed-off-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch