ext: fix init without oauthlib.client extension #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,7 +47,10 @@ def __init__(self, app): | |||
| # Connect signal to remove access tokens on logout | |||
| user_logged_out.connect(oauth_logout_handler) | |||
|
|
|||
| oauth = app.extensions['oauthlib.client'] | |||
| if 'oauthlib.client' in app.extensions: | |||
| oauth = app.extensions['oauthlib.client'] | |||
There was a problem hiding this comment.
please store the oauth on self
self.oauth = app.extensions.get('oauthlib.client')
if self.oauth is None:
self.oauth = FlaskOAuth() # NOTE no `app` argument as we are calling `init_app` later
# Add remote applications
self.oauth.init_app(app)
JavierDelgadoFernandez
force-pushed
the
flask_oauth_initialise
branch
2 times, most recently
from
d95f762
to
337c48a
Compare
|
@JavierDelgadoFernandez please wait for #25 to be merged first and then rebase. Thanks |
| @@ -46,21 +47,23 @@ def __init__(self, app): | |||
| # Connect signal to remove access tokens on logout | |||
| user_logged_out.connect(oauth_logout_handler) | |||
|
|
|||
| oauth = app.extensions['oauthlib.client'] | |||
| self.oauth = app.extensions.get('oauthlib.client') | |||
There was a problem hiding this comment.
self.oauth = app.extensions.get('oauthlib.client') or FlaskOAuth()?
JavierDelgadoFernandez
force-pushed
the
flask_oauth_initialise
branch
from
337c48a
to
e22c290
Compare
|
@jirikuncar Rebased. |
|
@JavierDelgadoFernandez please run |
* Fixes the initialization of the extension when there is no oauthlib.client object in extensions. Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
JavierDelgadoFernandez
force-pushed
the
flask_oauth_initialise
branch
from
e22c290
to
357b1f6
Compare
|
@jirikuncar Sorry, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauthlib.client object in extensions.
Signed-off-by: Javier Delgado javier.delgado.fernandez@cern.ch