global: fix user register #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Save token if used is authenticated | ||
| if current_user.is_authenticated: | ||
| uid = current_user.get_id() | ||
| # Save token if used is not anonymous (user exists but can be not active at |
There was a problem hiding this comment.
# Save token if user is not anonymous ...
hachreak
force-pushed
the
fix_register_orcid
branch
from
6edddfc
to
07eafa9
Compare
| 'OAUTHCLIENT_REMOTE_APPS'] | ||
| [remote.name].get('remember', False)): | ||
| # redirect the user after registration (which doesn't include the | ||
| # activation), waiting user confirm his email |
There was a problem hiding this comment.
waiting for user to confirm his email.
hachreak
force-pushed
the
fix_register_orcid
branch
2 times, most recently
from
f2cdc1d
to
7a0da33
Compare
| @@ -115,11 +117,15 @@ | |||
| DEBUG=True, | |||
| SECRET_KEY='TEST', | |||
| SECURITY_PASSWORD_SALT='security-password-salt', | |||
| SECURITY_LOGIN_WITHOUT_CONFIRMATION=False, | |||
| # MAIL_SUPPRESS_SEND=False, | |||
There was a problem hiding this comment.
IMHO we can remove this comment and TESTING. Thanks
* Introduces the possibility to "ask for email confirmation" in case the provider does not return any user email (e.g. with orcid). Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
force-pushed
the
fix_register_orcid
branch
from
7a0da33
to
2a20c48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the provider doesn't return any user email (e.g. with orcid).
Signed-off-by: Leonardo Rossi leonardo.r@cern.ch