Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting versions of uritemplate library #324

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

mesemus
Copy link
Contributor

@mesemus mesemus commented Mar 20, 2024

❤️ Thank you for your contribution!

Description

This pull request fixes issue #299 - conflicting versions of the uritemplate library. Invenio sources in general use the uritemplate library, but this module uses the uritemplate-py library. Both of the libraries provide the same top-level uritemplate python module and the one used depends on the installation order.

In the pull request, the uritemplate-py library was replaced with uritemplate.

Note: it seems that invenio-theme 3.0.0 does not include flask-breadcrumbs anymore and this library depends on that. flask-breadcrumbs were added to test dependencies, not sure if it is correct.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@mesemus mesemus changed the title Updated dependencies, removed unused import Fix conflicting versions of uritemplate library Mar 20, 2024
Copy link
Contributor

@jrcastro2 jrcastro2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a comment about removing flask-breadcrumbs, tests might fail in the meantime but we have to remove it as it's not needed anymore.We will fix the tests this afternoon most likely.

setup.cfg Outdated Show resolved Hide resolved
mesemus and others added 2 commits March 23, 2024 14:40
as those will be removed from all libraries

Co-authored-by: Javier <jrcastro9515@gmail.com>
@kpsherva kpsherva merged commit ba8f7ff into inveniosoftware:master Mar 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released | Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

3 participants