global: new configurable OAuthRemoteApp factory #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from .utils import load_or_import_from_config, obj_or_import_string | ||
|
|
||
|
|
||
| def _default_remote_app_factory(oauth): |
There was a problem hiding this comment.
def _default_remote_app_factory(oauth):
"""Default remote OAuth application factory."""
return oauth.remote_app?
nharraud
force-pushed
the
client-factory
branch
from
48ed0f4
to
ec04c44
Compare
nharraud
force-pushed
the
client-factory
branch
from
ec04c44
to
0ca9774
Compare
| @@ -26,6 +26,8 @@ | |||
| an access token. **Default:** ``oauth_token``. | |||
| `OAUTHCLIENT_STATE_EXPIRES` Number of seconds after which the state token | |||
| expires. Defaults to 300 seconds. | |||
| `OAUTHCLIENT_REMOTE_APP_FACTORY` Replaces the default remote application | |||
nharraud
force-pushed
the
client-factory
branch
from
0ca9774
to
845225d
Compare
| @@ -52,14 +53,26 @@ def __init__(self, app): | |||
| # Add remote applications | |||
| self.oauth.init_app(app) | |||
|
|
|||
| remote_app_class = load_or_import_from_config( | |||
| 'OAUTHCLIENT_REMOTE_APP', app, | |||
There was a problem hiding this comment.
just for better consistency:
- 'OAUTHCLIENT_REMOTE_APP', app,
- OAuthRemoteApp)
+ 'OAUTHCLIENT_REMOTE_APP', app, default=OAuthRemoteApp
+ )
|
Apart of some styling it looks good. |
nharraud
force-pushed
the
client-factory
branch
from
845225d
to
e51454d
Compare
nharraud
force-pushed
the
client-factory
branch
from
e51454d
to
d033b02
Compare
* NEW Enables to create custom OAuthRemoteApp instances by replacing the default remote application factory. (closes inveniosoftware#45) Signed-off-by: Nicolas Harraudeau <nicolas.harraudeau@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the default remote application factory. (closes global: configurable OAuthRemoteApp factory #45)
Signed-off-by: Nicolas Harraudeau nicolas.harraudeau@cern.ch