global: sqlalchemy relationships refactor #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which problem does this fix solve? |
|
None, just convenience of having consistent ORM definitions across modules. |
| @@ -16,3 +16,4 @@ | |||
| # You should have received a copy of the GNU General Public License | |||
| # along with Invenio; if not, write to the Free Software Foundation, Inc., | |||
| # 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA. | |||
| """OAuthClient unit tests.""" | |||
There was a problem hiding this comment.
We should remove __init__.py file from tests.
There was a problem hiding this comment.
Actually it's needed for importing tests/helpers.py: https://github.com/inveniosoftware/invenio-oauthclient/blob/master/tests/test_contrib_cern.py#L32
There was a problem hiding this comment.
from helper import ... will work without __init__.py
|
@krzysztof |
* Fixes the backref relationships in models. Signed-off-by: Krzysztof Nowak <k.nowak@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Nowak k.nowak@cern.ch