Skip to content

Commit

Permalink
global: flask_cli dependency removal
Browse files Browse the repository at this point in the history
Signed-off-by: Krzysztof Nowak <k.nowak@cern.ch>
  • Loading branch information
Krzysztof Nowak committed Nov 1, 2016
1 parent 476658d commit 0d738c4
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 10 deletions.
2 changes: 0 additions & 2 deletions examples/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@

from flask import Flask
from flask_babelex import Babel
from flask_cli import FlaskCLI
from invenio_db import InvenioDB, db
from invenio_pidstore import InvenioPIDStore
from invenio_records import InvenioRecords
Expand All @@ -48,7 +47,6 @@
# Create Flask application
app = Flask(__name__)
Babel(app)
FlaskCLI(app)
InvenioDB(app)
InvenioRecords(app)
InvenioPIDStore(app)
Expand Down
2 changes: 0 additions & 2 deletions examples/harvest.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
from flask import Flask
from flask_babelex import Babel
from flask_celeryext import create_celery_app
from flask_cli import FlaskCLI
from invenio_celery import InvenioCelery
from invenio_db import InvenioDB, db
from invenio_jsonschemas import InvenioJSONSchemas
Expand All @@ -53,7 +52,6 @@
# Create Flask application
app = Flask(__name__)
Babel(app)
FlaskCLI(app)
InvenioDB(app)
InvenioRecords(app)
InvenioCelery(app)
Expand Down
2 changes: 1 addition & 1 deletion invenio_openaire/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
import os

import click
from flask_cli import with_appcontext
from flask.cli import with_appcontext

from invenio_openaire.loaders import OAIREDumper
from invenio_openaire.tasks import harvest_fundref, harvest_openaire_projects
Expand Down
3 changes: 1 addition & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
import pytest
from elasticsearch.exceptions import RequestError
from flask import Flask
from flask_cli import FlaskCLI, ScriptInfo
from flask.cli import ScriptInfo
from flask_login import LoginManager
from invenio_celery import InvenioCelery
from invenio_db import db as db_
Expand Down Expand Up @@ -103,7 +103,6 @@ def app(request):
app.url_map.converters['pid'] = PIDConverter
app.url_map.converters['pidpath'] = PIDPathConverter

FlaskCLI(app)
LoginManager(app)
InvenioDB(app)
InvenioIndexer(app)
Expand Down
3 changes: 0 additions & 3 deletions tests/test_invenio_openaire.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
from __future__ import absolute_import, print_function

from flask import Flask
from flask_cli import FlaskCLI

from invenio_openaire import InvenioOpenAIRE

Expand All @@ -41,12 +40,10 @@ def test_version():
def test_init():
"""Test extension initialization."""
app = Flask('testapp')
FlaskCLI(app)
ext = InvenioOpenAIRE(app)
assert 'invenio-openaire' in app.extensions

app = Flask('testapp')
FlaskCLI(app)
ext = InvenioOpenAIRE()
assert 'invenio-openaire' not in app.extensions
ext.init_app(app)
Expand Down

0 comments on commit 0d738c4

Please sign in to comment.