Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: improve grant import and search #60

Merged
merged 6 commits into from Oct 23, 2019
Merged

global: improve grant import and search #60

merged 6 commits into from Oct 23, 2019

Conversation

ChiaraBi
Copy link
Member

@ChiaraBi ChiaraBi commented Oct 17, 2019 •
edited

@ChiaraBi ChiaraBi changed the title loaders: fix funders import global: improve grant import task Oct 18, 2019
@ChiaraBi ChiaraBi changed the title global: improve grant import task global: improve grant import and search Oct 22, 2019
@slint slint requested a review from Glignos October 23, 2019 09:07
slint
slint reviewed Oct 23, 2019
View reviewed changes
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Glignos you can take this over and make the review/fixes, and also push a release commit

invenio_openaire/indexer.py Outdated
json.get('acronym'),
json.get('title')
]
if "_" in code:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this might be None, there are some safety checks to do.

Glignos
Glignos approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@Glignos Glignos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slint slint merged commit b6477c2 into inveniosoftware:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slint slint slint left review comments

@Glignos Glignos Glignos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grants: SNF grants ids are not searchable
3 participants
@ChiaraBi @slint @Glignos