Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation: upgrade invenio-i18n #31

Merged
merged 10 commits into from
Nov 30, 2023

Conversation

kpsherva
Copy link
Contributor

@kpsherva kpsherva commented Nov 23, 2023

* remove deprecated flask-babelex import
@kpsherva kpsherva force-pushed the deprecate-flask-babelex branch 3 times, most recently from 51942d6 to 8913e32 Compare November 23, 2023 10:23
@kpsherva kpsherva force-pushed the deprecate-flask-babelex branch 2 times, most recently from 5851b1a to 7dba4b4 Compare November 23, 2023 12:42
@kpsherva kpsherva force-pushed the deprecate-flask-babelex branch 2 times, most recently from 961ce1e to 00e7e33 Compare November 23, 2023 15:00
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, curious about the @compiles usage.

Comment on lines 46 to 48
@compiles(DropTable, "postgresql")
def _compile_drop_table(element, compiler, **kwargs):
return compiler.visit_drop_table(element) + " CASCADE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: what is this sorcery?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄 It was a test

@kpsherva kpsherva merged commit 9a41d77 into inveniosoftware:master Nov 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade invenio packages
2 participants