-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installation: upgrade invenio-i18n #31
installation: upgrade invenio-i18n #31
Conversation
kpsherva
commented
Nov 23, 2023
•
edited
Loading
edited
- remove deprecated flask-babelex import
- closes Upgrade invenio packages invenio-app-ils#1188
* remove deprecated flask-babelex import
51942d6
to
8913e32
Compare
8913e32
to
af48426
Compare
5851b1a
to
7dba4b4
Compare
7dba4b4
to
130bf13
Compare
961ce1e
to
00e7e33
Compare
00e7e33
to
7521ff4
Compare
45dd063
to
17f507e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, curious about the @compiles
usage.
tests/conftest.py
Outdated
@compiles(DropTable, "postgresql") | ||
def _compile_drop_table(element, compiler, **kwargs): | ||
return compiler.visit_drop_table(element) + " CASCADE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: what is this sorcery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪄 It was a test
3884742
to
f340ece
Compare