Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: PDFJS toolbar fixes #23

Merged

Conversation

JavierDelgadoFernandez
Copy link
Contributor

  • Fixes the issues with the toolbar buttons updating the npm package
    to the official repository.

Signed-off-by: Javier Delgado javier.delgado.fernandez@cern.ch

@JavierDelgadoFernandez JavierDelgadoFernandez changed the title extensions: PDFJS toobar fixes extensions: PDFJS toolbar fixes Apr 4, 2016
@JavierDelgadoFernandez JavierDelgadoFernandez force-pushed the pdfjs_polishing branch 3 times, most recently from c276681 to 47b4e69 Compare April 5, 2016 11:42
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.744% when pulling 47b4e69 on JavierDelgadoFernandez:pdfjs_polishing into d4f8167 on inveniosoftware:master.

@JavierDelgadoFernandez
Copy link
Contributor Author

@lnielsen It is ready from my side.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 92.966% when pulling 1f1c6a1 on JavierDelgadoFernandez:pdfjs_polishing into 2ab92c0 on inveniosoftware:master.

@JavierDelgadoFernandez
Copy link
Contributor Author

@lnielsen Rebased

"node_modules/pdf-viewer/ready/generic/build/pdf.js",
"node_modules/pdf-viewer/ready/generic/build/pdf.worker.js",
"js/pdfjs/pdf_viewer.js",
"js/zip/fullscreen.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..

* Adds the locale and image files from the official distribution which
  are not provided by the official NPM package.

Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
* Fixes the issues with the toolbar buttons updating the npm package
  to the official repository.

Signed-off-by: Javier Delgado <javier.delgado.fernandez@cern.ch>
@coveralls
Copy link

coveralls commented May 17, 2016

Coverage Status

Coverage decreased (-0.02%) to 93.215% when pulling 9b76a2c on JavierDelgadoFernandez:pdfjs_polishing into 4998a05 on inveniosoftware:master.

@JavierDelgadoFernandez
Copy link
Contributor Author

@lnielsen Updated and ready from my side.

@lnielsen lnielsen merged commit 9b76a2c into inveniosoftware:master May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants