api: support unicode filenames

Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@gmail.com>
inveniosoftware · Nov 28, 2017 · 9715a29 · 9715a29
1 parent 8988189
commit 9715a29
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/invenio_records_files/api.py b/invenio_records_files/api.py
@@ -154,7 +154,7 @@ def __next__(self):
     def __contains__(self, key):
         """Test if file exists."""
         return ObjectVersion.get_by_bucket(
-            self.bucket).filter_by(key=str(key)).count()
+            self.bucket).filter_by(key=key).count()
 
     def __getitem__(self, key):
         """Get a specific file."""

diff --git a/tests/test_invenio_records_files.py b/tests/test_invenio_records_files.py
@@ -128,6 +128,14 @@ def test_files_property(app, db, location, bucket):
     assert 'hello.txt' in record.files
 
 
+def test_files_unicode(app, db, location, record_with_bucket):
+    record = record_with_bucket
+
+    # Create a file with a unicode filename.
+    record.files[u'hellö.txt'] = BytesIO(b'Hello world!')
+    assert u'hellö.txt' in record.files
+
+
 def test_files_extra_data(app, db, location, record_with_bucket):
     """Test record files property."""
     record = record_with_bucket