Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: renaming of example folder to examples #11

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

drjova
Copy link
Member

@drjova drjova commented Jul 26, 2016

Signed-off-by: Harris Tzovanakis me@drjova.com

@drjova drjova added this to the v1.0.0 milestone Jul 26, 2016
@drjova drjova changed the title global: harmonize example folder global: rename of example folder to examples Jul 26, 2016
@jirikuncar jirikuncar self-assigned this Jul 26, 2016
@jirikuncar jirikuncar changed the title global: rename of example folder to examples global: renaming of example folder to examples Jul 26, 2016
@@ -1,7 +0,0 @@
<div ng-show="recordsVM.invenioRecordsError.data.message" class="alert alert-danger">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drjova is this an intended change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we use invenio-records-alert with alert.html template

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh ok. But shouldn't this change be a separate commit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drjova drjova removed their assignment Jul 26, 2016
@jirikuncar
Copy link
Member

@drjova git commit --amend & s/rename/renaming/

Signed-off-by: Harris Tzovanakis <me@drjova.com>
@drjova drjova removed their assignment Jul 26, 2016
@jirikuncar jirikuncar merged commit 3b9cf4a into inveniosoftware:master Jul 26, 2016
@drjova drjova deleted the examples-renaming branch July 26, 2016 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants