Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: autosuggestion parameters modification #15

Merged
merged 1 commit into from
Aug 17, 2016

Conversation

slint
Copy link
Member

@slint slint commented Aug 16, 2016

  • Treats keys set to 'value' in the ui-select's urlParameters options
    as the user's input query.
  • Transforms autosuggest results name and value from options map.
  • Handles initial load values for autosuggest fields.

Signed-off-by: Alexander Ioannidis a.ioannidis@cern.ch

"angular-schema-form-dynamic-select": "^0.13.1",
"angular-strap": "^2.3.9",
"angular-translate": "^2.11.0",
"angular-ui-select": "^0.12.100",
"angular-ui-sortable": "^0.14.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it? :)

@drjova
Copy link
Member

drjova commented Aug 17, 2016

Just the two comments otherwise LGTM 👍

* Treats keys set to 'value' in the ui-select's urlParameters options
  as the user's input query.

* Transforms autosuggest results name and value from options map.

* Handles initial load values for autosuggest fields.

Signed-off-by: Alexander Ioannidis <a.ioannidis@cern.ch>
@lnielsen lnielsen merged commit 9aed885 into inveniosoftware:master Aug 17, 2016
@slint slint deleted the autosuggest_params branch August 17, 2016 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants