Expandable fields: Skip expansion if the value or service is None #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
max-moser
force-pushed
the
mm/access-requests
branch
from
8afb228
to
42c9a21
Compare
max-moser
force-pushed
the
mm/access-requests
branch
from
42c9a21
to
3bac9b2
Compare
zzacharo
reviewed
Jul 4, 2023
| v, service = field.get_value_service(value) | ||
| if v is None or service is None: | ||
| continue |
There was a problem hiding this comment.
How would the grants be expanded then? Reading the premise of the PR, you skip resolving but would you still use an expandable field?
* some entities are abstract and not backed by a service, like system roles
max-moser
force-pushed
the
mm/access-requests
branch
from
3bac9b2
to
3a72837
Compare
|
Added a dummy service in RDM-Records for the entities in question, so this isn't necessary anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some entities are abstract and not backed by a service, like system roles.
It might be however that we encounter such entities during expansion, among others.
One such case is the expansion process for access grants, which allows the referenced entities to be users (:heavy_check_mark: ), roles (:heavy_check_mark:) or system roles (:x:).
This PR chooses to ignore/skip entities that don't have a service with which to resolve them, because that's simpler than adding code in other places that checks for entity types explicitly before trying to dump result lists with expansion on.