Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: refactored sort fields computation. #481

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

alejandromumo
Copy link
Member

@alejandromumo alejandromumo commented Aug 8, 2023

closes inveniosoftware/invenio-rdm-records#1398

WHY THIS PR:

  • I need to implement a type of SortParam, where the fields are computed in the same way as the parent except that, in the new interpreter, the fields are always prepended by a new field.
  • To avoid code duplication, I refactored the apply method to just apply the fields to the search's sort instead of computing the fields + applying them.
  • Added a service call to reindex records by the latest version first.
    • The idea is to speed up the reindexing of the latest versions while the other versions can be done, in bulk, separately.
  • Added a new UOW operation for bulk indexing records, given an iterable of ids (e.g. a generator)

@ntarocco ntarocco merged commit 227fd60 into inveniosoftware:master Aug 14, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[USER MODERATION] - 3rd deliverable - sort records by 'verified'
2 participants