views: small fix on pass_record raise block #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnielsen
moved this from Pending review
to Pending merge
in Files bundle sprint (July 22 to Aug 2)
diegodelemos
approved these changes
Jul 22, 2019
diegodelemos
moved this from Pending merge
to In progress
in Files bundle sprint (July 22 to Aug 2)
diegodelemos
moved this from In progress
to Blocked
in Files bundle sprint (July 22 to Aug 2)
* pin pytest, upgrade sphinx, pin dist to trusty, remove ES2
diegodelemos
force-pushed
the
fix-pass-record-on-expection
branch
from
4ae4f14
to
fa4d7bf
Compare
|
@diegodelemos Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error matches with the title of #243
local variable 'pid' referenced before assignmentbut the description of that issue seems to be for something different so I didn't add the closes ...Also, I made the PR on
main-1.2because https://invenio.readthedocs.io/en/latest/releases/maintenance-policy.html#policyLet me know if you want to change this.