travis: fix mysql fractional seconds #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
force-pushed
the
fix-fractional-seconds
branch
6 times, most recently
from
b5b4b26
to
8c48831
Compare
Signed-off-by: Harris Tzovanakis <me@drjova.com>
switowski
reviewed
Oct 12, 2017
| @@ -35,6 +36,7 @@ | |||
| class RecordMetadataModelView(ModelView): | |||
| """Records model view.""" | |||
|
|
|||
| filter_converter = FilterConverter() | |||
There was a problem hiding this comment.
Is this related with the fractions of seconds? Or is it a separate thing (or maybe you forgot to remove it)?
There was a problem hiding this comment.
it is related with the model, flask-admin complains for missing filters beacuse we are not using sqlalchemy_utils.models::Timestamp anymore
drjova
force-pushed
the
fix-fractional-seconds
branch
from
8c48831
to
071447a
Compare
switowski
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harris Tzovanakis me@drjova.com