Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: fix for mysql uuid #213

Closed
wants to merge 1 commit into from

Conversation

roksys
Copy link

@roksys roksys commented Nov 12, 2019

@roksys roksys added this to Backlog in Sprint Week 46-47 (2019) - V3.2 Release via automation Nov 12, 2019
@roksys roksys moved this from Backlog to Pending review in Sprint Week 46-47 (2019) - V3.2 Release Nov 12, 2019
@kpsherva kpsherva self-assigned this Nov 12, 2019
Copy link
Contributor

@kpsherva kpsherva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've investigated the issue a bit and there are my findings:
thebinary=False option will actually cause allocating more resources for the uuids (which might be an issue when we have a lot of records
also I have checked step by step, and uuid is deserialised properly in the UUIDType
the POST is handled correctly
the problem is when we try to hit records/1 in the debug mode -> when the debug sidebar is visible
the object gets into the template of the debug sidebar with still byte string not being encoded

Screenshot 2019-11-12 at 17 47 59
(check pid row)

@kpsherva kpsherva moved this from Pending review to In progress in Sprint Week 46-47 (2019) - V3.2 Release Nov 12, 2019
@kpsherva kpsherva assigned roksys and unassigned kpsherva Nov 12, 2019
@roksys roksys closed this Nov 13, 2019
Sprint Week 46-47 (2019) - V3.2 Release automation moved this from In progress to Done Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants