config: fix typo on configuration variable #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Newer versions of s3fs (> 0.3.0) only support python >= 3.5
egabancho
force-pushed
the
fix-config-typo
branch
from
6d28acd
to
5bad54f
Compare
lnielsen
reviewed
Oct 7, 2019
| @@ -47,7 +47,7 @@ | |||
| install_requires = [ | |||
| 'boto3>=1.9.83', | |||
| 'invenio-files-rest>=1.0.0a23', | |||
| 's3fs>=0.1.5', | |||
| 's3fs>=0.1.5,<0.3.0', # Newer versions only allow python >= 3.5 | |||
There was a problem hiding this comment.
We can remove python 2 support if you like. Since this module won't be in production until after January 2020.
There was a problem hiding this comment.
There is nothing I would love more than removing python 2.7 support, but I know at least one production system using it, I'll check with them what python version they are using and fix this accordingly
lnielsen
approved these changes
Oct 7, 2019
* Fix typo on `S3_ACCCESS_KEY_ID` and S3_SECRET_ACCESS_KEY, (too many Cs) and add a deprecation warning for the old key. (closes inveniosoftware#3)
egabancho
force-pushed
the
fix-config-typo
branch
from
5bad54f
to
fbfc44d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3_ACCCESS_KEY_ID, (too many Cs) and add a deprecationwarning for the old key. (closes Typo in config variable
S3_ACCCESS_KEY_IDS3_ACCESS_KEY_ID(too many Cs) #3)