Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: removes example app test #200

Merged
merged 2 commits into from
May 7, 2020

Conversation

Glignos
Copy link
Member

@Glignos Glignos commented May 5, 2020

@Glignos
Copy link
Member Author

Glignos commented May 5, 2020

Passed build

Copy link
Member

@ppanero ppanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Glignos just a minor. Feel free to take it or leave it, I can simply trigger the build when releasing.

CHANGES.rst Outdated
@@ -8,6 +8,11 @@
Changes
=======

Version 1.3.1 (released TBD)

- set Sphinx ``<3`` because of errors related to application context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: since we have to trigger build here (just to have one passing and not merge force, checked the passed link thanks for that ;)

Can it be changed to:

  • Start items with capitals.
  • End sentences with dots.
  • Expand versions (i.e. 3.0.0).

Mainly to be consistent with the rest of the CHANGES.rst file (yes we need a common one for Invenio 😅 )

@diegodelemos diegodelemos merged commit 65800b0 into inveniosoftware:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release 1.3.1 tests: fix build error by removing example app.
3 participants