API for managing SIP models #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added class `SIPMetadata` to be able to have multiple metadata - added attribute `archive` (boolean) to say if the content should be archived or not
- updated the model views to integrate the new fields - added the model view for SIPMetadata with links to SIP
remileduc
force-pushed
the
archivematica_support
branch
from
a670152
to
8ff0b8f
Compare
remileduc
force-pushed
the
archivematica_support
branch
from
8ff0b8f
to
50e0313
Compare
remileduc
commented
May 31, 2017
| @@ -66,7 +67,7 @@ | |||
| 'invenio-accounts>=1.0.0a10', | |||
| 'invenio-pidstore>=1.0.0a7', | |||
| 'invenio-jsonschemas>=1.0.0a3', | |||
| 'invenio-files-rest>=1.0.0a1', | |||
| 'invenio-files-rest>=1.0.0a14', | |||
There was a problem hiding this comment.
to use the bump version of fs: inveniosoftware/invenio-files-rest@bd3f879
lnielsen
reviewed
Jun 1, 2017
invenio_sipstore/models.py
Outdated
| @@ -71,24 +65,35 @@ class SIP(db.Model, Timestamp): | |||
| agent = db.Column(JSONType, default=lambda: dict(), nullable=False) | |||
| """Agent information regarding given SIP.""" | |||
|
|
|||
| archivable = db.Column( | |||
| db.Boolean(name='ck_sip_archivable'), | |||
- add a signal when a SIP is created from the API - 2 API classes: SIP and RecordSIP to manage the models based on Zenodo: https://github.com/zenodo/zenodo/blob/master/zenodo/modules/sipstore/api.py - add a function to automatically find the current storage location of a SIPFile - add a config variable to generate agent of the SIPs - updated tests
remileduc
force-pushed
the
archivematica_support
branch
from
50e0313
to
f034df6
Compare
|
ready to merge |
Merged
krzysztof
reviewed
Jul 10, 2017
| The created model is stored in the attribute 'model'. | ||
| :param bool archivable: tells if the SIP should be archived or not. | ||
| Usefull if ``Invenio-Archivematica`` is installed. | ||
| :param list files: The list of files to associate with the SIP. See |
There was a problem hiding this comment.
is :param <type> <name> a standard?
There was a problem hiding this comment.
krzysztof
reviewed
Jul 10, 2017
| @@ -71,24 +65,35 @@ class SIP(db.Model, Timestamp): | |||
| agent = db.Column(JSONType, default=lambda: dict(), nullable=False) | |||
| """Agent information regarding given SIP.""" | |||
|
|
|||
| archivable = db.Column( | |||
There was a problem hiding this comment.
Is this flag necessary? perhaps we could reduce it to a single "state" flag (enum)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Invenio-Archivematica (see #25)
archivableandarchivedbooleans on SIPSIPMetadatatable to enable the storage of multiple metadataAPI based on https://github.com/zenodo/zenodo/blob/master/zenodo/modules/sipstore/api.py