processors: calculate visitor_id and session_id #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
approved these changes
Jun 12, 2018
invenio_stats/processors.py
Outdated
| user_id = doc.pop('user_id', '') | ||
| session_id = doc.pop('session_id', '') | ||
| user_agent = doc.pop('user_agent', '') | ||
| timestamp = arrow.get(doc.get('timestamp')).replace(minute=0, second=0)\ |
invenio_stats/processors.py
Outdated
| session_id = doc.pop('session_id', '') | ||
| user_agent = doc.pop('user_agent', '') | ||
| timestamp = arrow.get(doc.get('timestamp')).replace(minute=0, second=0)\ | ||
| .isoformat() | ||
|
|
||
| m = hashlib.sha224() |
There was a problem hiding this comment.
consistent naming with visitor_id (also for unique_session_id)
ChiaraBi
force-pushed
the
anonymize_user
branch
5 times, most recently
from
ef96f6e
to
79b44d5
Compare
slint
approved these changes
Jun 14, 2018
invenio_stats/processors.py
Outdated
| user_id = doc.pop('user_id', '') | ||
| session_id = doc.pop('session_id', '') | ||
| user_agent = doc.pop('user_agent', '') | ||
| timestamp = arrow.get(doc.get('timestamp')).strftime('%Y%m%d%H') |
There was a problem hiding this comment.
Maybe rename this to timeslice and explain in a comment what this is (w.r.t. COUNTER terminology)
ChiaraBi
force-pushed
the
anonymize_user
branch
2 times, most recently
from
cf1c4ae
to
8744ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.