global: configurable aggregations #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nharraud
reviewed
Jul 20, 2017
invenio_stats/contrib/events.py
Outdated
| """Register sample events.""" | ||
| return [dict(event_type='file-download', | ||
| processor=EventsIndexer), | ||
| dict(event_type='record-view', | ||
| processor=EventsIndexer)] | ||
|
|
||
|
|
||
| def register_aggregations(): |
There was a problem hiding this comment.
The file is name events.py. We should find a more appropriate name if we also put the aggregations there.
There was a problem hiding this comment.
Changed to registrations.py
nharraud
reviewed
Jul 20, 2017
invenio_stats/contrib/events.py
Outdated
|
|
||
| def register_aggregations(): | ||
| """Register sample aggregations.""" | ||
| return [dict(event_type='file-download', |
There was a problem hiding this comment.
The name should not be the name of an event type. We could have multiple aggregations based on the same events.
There was a problem hiding this comment.
Changed to aggregation_name
dinosk
force-pushed
the
aggs
branch
5 times, most recently
from
2ef5beb
to
49966de
Compare
* ADDS loading of aggregation logic from entrypoints Signed-off-by: Dinos Kousidis <konstantinos.kousidis@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dinos Kousidis konstantinos.kousidis@cern.ch