Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages: fix top margin in flashed messages #183

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

zzacharo
Copy link
Member

closes #167

@zzacharo zzacharo assigned zzacharo and unassigned zzacharo Jun 17, 2020
@zzacharo zzacharo added this to In progress in InvenioRDM June Board via automation Jun 17, 2020
@zzacharo zzacharo moved this from In progress to In Review in InvenioRDM June Board Jun 17, 2020
@zzacharo
Copy link
Member Author

Flash messages are attached to header with no space in between and also the border of the message is not rounded. Is this what we want @lnielsen ? I assume yes but just for the verification :)

Screenshot 2020-06-17 at 15 52 29

@zzacharo
Copy link
Member Author

There is also another possibility similar to https://zenodo.org:

Screenshot 2020-06-18 at 10 06 43

Here the flashed message is center and dismissals. @lnielsen which one do you prefer?

@lnielsen lnielsen merged commit 0a4bab7 into inveniosoftware:master Jun 19, 2020
InvenioRDM June Board automation moved this from In Review to Done Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

semantic-ui: flash message should be attached to header
2 participants