Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: message flash fix #4

Merged
merged 1 commit into from
Oct 21, 2015
Merged

templates: message flash fix #4

merged 1 commit into from
Oct 21, 2015

Conversation

lnielsen
Copy link
Member

  • Fixes issue with message flashing not displaying the actual message.
  • Sets default category to 'info'.

Signed-off-by: Lars Holm Nielsen lars.holm.nielsen@cern.ch

@lnielsen lnielsen added this to the v1.0.0 milestone Oct 18, 2015
@lnielsen lnielsen assigned lnielsen and nharraud and unassigned lnielsen Oct 18, 2015
@nharraud
Copy link
Member

By the way, do we still want to keep both error and danger categories? I thought we kept it only for backward compatibility. As we are cleaning legacy we might as well keep only one of them. It would make doc simpler as we currently have for each flash message category a corresponding CSS class alert-<CATEGORY> except for error which is mapped to alert-danger.

@lnielsen
Copy link
Member Author

@nharraud Yes, let's get rid of error. What about (html_safe)? Seems to me that we should also remove that and by default escape all message. If you want to have HTML in the message, you then have to pass the string explicitly through MarkupSafe in the code, which I think is better.

@lnielsen
templates: message flash fix
3e899e6 
* Fixes issue with message flashing not displaying the actual message.

* Sets default category to 'info'.

Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
@lnielsen
Copy link
Member Author

Updated.

@lnielsen
Copy link
Member Author

@nharraud Will you merge this PR?

@nharraud
Copy link
Member

I don't have the write permission yet. @jirikuncar just told me that he will merge it and give me the access rights at the same time.

@jirikuncar jirikuncar merged commit 3e899e6 into inveniosoftware:master Oct 21, 2015
switowski pushed a commit to switowski/invenio-theme that referenced this pull request May 14, 2018
@ludmilamarian @jirikuncar
oauthclient: improvements to the CERN oauthclient
4cc2bc9 
* BETTER Improves the account setup for the CERN oauthclient.

* FIX Sends a validation email only if the option is enabled
  in the config.  (closes inveniosoftware#4)

Reviewed-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Ludmila Marian <ludmila.marian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nharraud nharraud

Labels
Type: bug
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lnielsen @nharraud @jirikuncar