roles: changed need creation by role name to id

inveniosoftware · Aug 9, 2023 · c0ae04e · c0ae04e
1 parent ef490d8
commit c0ae04e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/invenio_users_resources/entity_resolvers.py b/invenio_users_resources/entity_resolvers.py
@@ -113,9 +113,7 @@ def _resolve(self):
         # Resolves to role name, not id
         role_id = self._parse_ref_dict_id()
         try:
-            return Role.query.filter(
-                Role.name == role_id  # TODO to be changed to role id
-            ).one()
+            return Role.query.filter(Role.id == role_id).one()
         except NoResultFound:
             return {}
 

diff --git a/invenio_users_resources/services/generators.py b/invenio_users_resources/services/generators.py
@@ -13,7 +13,6 @@
 from functools import reduce
 from itertools import chain
 
-from flask_principal import RoleNeed
 from invenio_records_permissions.generators import Generator, UserNeed
 from invenio_search.engine import dsl