Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permissions: allow moderators to read emails #107

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

kpsherva
Copy link
Contributor

@kpsherva kpsherva commented Sep 4, 2023

FAQ

  • administration of users was moved to app-rdm because of common components with users moderations (which requires requests) - I found it better to move it "lower" than causing circular imports

resource: expose search all users endpoint
@@ -1,23 +1,46 @@
{
"settings": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this analyzer is needed to extract email domains to multifield: email.domain (see mapping of the email field)

},
"analyzer": {
"email": {
"tokenizer": "uax_url_email",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tokenizer for the email is needed to keep the email as one token, otherwise ES creates many tokens on the email and can be confusing when searching - we learned that from user feedback in ILS (check ES docs)

"type": "text"
"type": "text",
"fields": {
"keyword": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for aggs

"links": {"avatar": avatar},
"links": resolved_dict.get("links"),
"blocked_at": resolved_dict.get("blocked_at"),
"verified_at": resolved_dict.get("verified_at"),
Copy link
Contributor Author

@kpsherva kpsherva Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be confirmed if we can expand those fields - they are added to the field_permission_dump, but this might not be enough

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My hunch is that if we're using email as above, this goes through the service and gets properly filtered, in which case any attribute would be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true! thanks

@kpsherva kpsherva force-pushed the user-moderation branch 3 times, most recently from d0d87d0 to f0fd0af Compare September 8, 2023 14:56
search: add user facets
@kpsherva kpsherva merged commit b08c61b into inveniosoftware:master Sep 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[USER MODERATION] - 6th deliverable - Implement UI Field "is_verified" dump permissions
2 participants