Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for ListIdentifiers implementation are running. #345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wgresshoff
Copy link
Contributor

❤️ Thank you for your contribution!

Description

As follow-up for the first PR where the ListRecords based method was implemented, now the missing ListIdentifiers based approach is added. This should avoid time outs with outdated resumption tokens.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@wgresshoff wgresshoff force-pushed the 321-implement-listidentifiers branch from f6b4f9d to 711d79a Compare June 19, 2024 15:17
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small question

yield {"record": record}
except NoRecordsMatch:
raise ReaderError(f"No records found in OAI-PMH request.")
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other verbs folks might use? Should there be an error that they aren't implemented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point, because the design follows the verbs that are defined by OAI-PMH. I chose them to offer familiar terms to the admins and wasn't aware of the drawback. But the usage is safe in the sense you can put in every verb you like and the harvester does it's work (perhaps in a way the suer doesn't expect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants