Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: read_all tested with and without cache #52

Merged
merged 1 commit into from
Jun 21, 2021
Merged

test: read_all tested with and without cache #52

merged 1 commit into from
Jun 21, 2021

Conversation

effervescent-shot
Copy link
Contributor

Closes #50

ppanero
ppanero approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@ppanero ppanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 2 minor comments :) It can be merged once they are addressed.

Maybe we should open an issue for the last discussion point.

tests/conftest.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/services/test_service.py Outdated Show resolved Hide resolved
@lnielsen lnielsen merged commit 727eb81 into inveniosoftware:master Jun 21, 2021
@ppanero ppanero mentioned this pull request Jun 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppanero ppanero ppanero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests: implement tests for read_all with and without cache
3 participants
@effervescent-shot @ppanero @lnielsen