Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in setting the restriction access with bibupload and bibdocfile #1080

Closed
kaplun opened this issue Apr 30, 2014 · 5 comments
Closed

Comments

@kaplun
Copy link
Member

kaplun commented Apr 30, 2014

Originally

[...]

I try to set an access restriction to a file when I add it by setting the FFT field in a record, for example:

<record>
    <controlfield tag="001">22129</controlfield>
    <datafield tag ="FFT" ind1=" " ind2=" ">
       <subfield code="r">RERO_CENTRAL</subfield>
       <subfield code="a">http://doc.rero.ch/lm.php?url=1000,43,4,20120605120440-CJ/Thai_Trieu-Tien_-_Arene_ruthenium_bis-saccharinato_complexes_Synthesis_20120605.pdf</subfield>
      </datafield>
</record>

After bibuploading the record (using bibupload -ri), the restriction is not set.

Once the file is added, I run bibdocfile with -r flag and it works!
[...]

@kaplun kaplun self-assigned this May 1, 2014
@kaplun
Copy link
Member Author

kaplun commented May 1, 2014

Originally on 2012-06-05

Indeed bibupload --append or bibupload --insert --replace was forgetting to properly set restriction when elaborating FFT tags. This is fixed in the attached patch (against maint-1.0). Thanks Johnny for having reported it!

@invenio-developers
Copy link

Originally by Samuele Kaplun samuele.kaplun@cern.ch on 2012-06-06

In [56b96c4]:

#CommitTicketReference repository="" revision="56b96c4b6cd46bc7a4d22c9203a3ffcd73ef898b"
BibUpload: fix setting restriction in -a/-ir modes

- When using bibupload --append or bibupload --insert --replace,
  properly set the restriction status specified in FFT tags.
  (fixes #1080)

1 similar comment
@invenio-developers
Copy link

Originally by Samuele Kaplun samuele.kaplun@cern.ch on 2012-06-06

In [56b96c4]:

#CommitTicketReference repository="" revision="56b96c4b6cd46bc7a4d22c9203a3ffcd73ef898b"
BibUpload: fix setting restriction in -a/-ir modes

- When using bibupload --append or bibupload --insert --replace,
  properly set the restriction status specified in FFT tags.
  (fixes #1080)

@invenio-developers
Copy link

Originally by Samuele Kaplun samuele.kaplun@cern.ch on 2012-08-09

In 56b96c4:

#CommitTicketReference repository="" revision="56b96c4b6cd46bc7a4d22c9203a3ffcd73ef898b"
BibUpload: fix setting restriction in -a/-ir modes

- When using bibupload --append or bibupload --insert --replace,
  properly set the restriction status specified in FFT tags.
  (fixes #1080)

1 similar comment
@invenio-developers
Copy link

Originally by Samuele Kaplun samuele.kaplun@cern.ch on 2012-08-09

In 56b96c4:

#CommitTicketReference repository="" revision="56b96c4b6cd46bc7a4d22c9203a3ffcd73ef898b"
BibUpload: fix setting restriction in -a/-ir modes

- When using bibupload --append or bibupload --insert --replace,
  properly set the restriction status specified in FFT tags.
  (fixes #1080)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants