WebSearch: restricted records in latest additions #2145
Conversation
* When a record belongs to both a public and a restricted collection, no longer display it in the list of latest additions of the public collection (in accordance to the outcome of an empty search query over the public collection). (closes inveniosoftware#1315) * Amend documentation of CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY WRT default policy value. Signed-off-by: Samuele Kaplun <samuele.kaplun@cern.ch>
| ## Additionally, by default, since CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY | ||
| ## is set to ANY, any record belonging to a restricted | ||
| ## collection is entitled to be displayed in the | ||
| ## latest additions. |
There was a problem hiding this comment.
I have only one doubt here: currently when we display restricted collection splash pages such as: http://cds.cern.ch/collection/ATLAS%20Communications%20Physics?ln=en we indeed do not display any record (because not authenticated users can still access splash pages of restricted collection...
So here I think we should amend this patch to alway remove restricted records...
There was a problem hiding this comment.
@kaplun Yes, the splash pages are not under RBAC, so all restricted records should be removed on those pages for webcolling. Unless CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY is permissive. If it is not permissive, we should not display any record during webcolling.
There was a problem hiding this comment.
@kaplun Have you checked this case since?
There was a problem hiding this comment.
Actually nope, but I can give it one more look
no longer display it in the list of latest additions of the
public collection (in accordance to the outcome of an empty search query
over the public collection).
(closes Bug in latest addition WRT restricted records #1315)
WRT default policy value.
Signed-off-by: Samuele Kaplun samuele.kaplun@cern.ch