WIP base: rewrite apache configuration generator #2645

dset0x · 2015-01-06T13:48:56Z

The templates were merged into one, and so was the resulting
configuration file. Should the user need to enable or disable SSL for
example, the recommended way is to edit the invenio configuration and
re-run create-config.
All variables that are used in the template must now pass through
apache.py, even if no operation is performed on them. All logic
that does not logically belong in Jinja2 has been removed from the
template.
Apache version 2.2 OpenSSL 1.0.1e are now the minimum supported. These
are the official CentOS 6.6 packages.
mod_headers is now necessary. So is socache_shmcb for apache >= 2.3.3
in order to use SSLStaplingCache.
SSL allowed protocols and ciphers have been set according to mozilla's
recommendations.
The switches for inveniomanage apache create-config have changed:
--force was dropped as it was a NO-OP.
It is now possible to manually set the paths to the desired
certificates, as the following configuration directives have been
ported from zenodo: 'APACHE_CERTIFICATE_PEM_FILE',
'APACHE_CERTIFICATE_FILE', 'APACHE_CERTIFICATE_KEY_FILE'.
invenio/legacy/inveniocfg.py:_detect_ip_address exception handling
is improved and it now uses 'google.com' instead of 'invenio.org' to
test connectivity, because of their uptime.

jirikuncar · 2015-01-12T12:08:55Z

invenio/legacy/inveniocfg.py

@@ -832,9 +832,9 @@ def _detect_ip_address():
    """
    try:
        s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
-        s.connect(('invenio-software.org', 0))


I would keep the invenio-software.org

I understand this is not really part of this patch, but I expect google.com to have a greater uptime. Perhaps the issue is mentioning google in the code?

Perhaps the issue is mentioning google in the code?

invenio-software.org should be up and running if you want to install demosite hence it should be fine for this case too.

I may be missing something here. What is the relationship between invenio-software.org being up and someone creating the apache configuration for their website (it doesn't have to be the demosite).

Do not mention google in the code.

jirikuncar · 2015-01-12T12:10:18Z

@dset0x it looks good. If you are done, please remove WIP from the PR title, improve PEP8/257, rebase and re-push. Thanks

jirikuncar · 2015-02-20T08:16:36Z

invenio/base/scripts/apache.py

+try:
+    from shutil import which
+except ImportError:
+    from distutils.spawn import find_executable as which


Please check and amend invenio.utils.shell:which. Thank you

jirikuncar · 2015-02-20T08:21:40Z

Please add NOTE to commit message with explanation how to migrate current templates. (cc @lnielsen )

jirikuncar · 2015-02-20T08:23:50Z

@dset0x when you are done can you try to enable Apache tests in .travis.yml? Thank you

dset0x · 2015-02-20T09:06:02Z

@jirikuncar I have yet to see this run once:

@lovasko Any progress with testing this? Are there any tests other than wget -O /dev/null http://localhost you would like to see ran?

jirikuncar · 2015-02-20T09:08:03Z

Are there any tests other than wget -O /dev/null http://localhost you would like to see ran?

That one should be enough for now.

dset0x · 2015-02-20T22:21:59Z

invenio/base/scripts/apache.py

+                'login_url': app.config.get('SSO_LOGIN_URL', None)
+            }
+            if sso['enabled']:
+                assert sso.login_url is not None, 'SSO enabled by URL not set'


s/by /but /

large letters

dset0x · 2015-06-05T16:38:54Z

@kaplun Thanks for the heads up, but how ~~did~~ do you know? Was this openssl_md_meth_names issue manifesting itself elsewhere too?

Edit: The problem is still present in this PR.

kaplun · 2015-06-05T19:54:45Z

Ah nope sorry, I simply see that Travis succeeds right now. Also around on the web I have seen this was related to a temporary problem... Wasn't this PR blocked by the fact that Travis was not passing?

dset0x · 2015-06-05T20:35:12Z

I simply see that Travis succeeds right now.

I have edited travis.yml to continue after wget fails so that I can have it print some debugging information afterwards:

(regardless of it being temporarily marked as passing)

Wasn't this PR blocked by the fact that Travis was not passing?

Yes, but there is also a new problem now: #3077 (comment) . Unfortunately I have not gotten around to working towards some RFC about it, due to working on other modules.

jirikuncar · 2015-07-16T19:11:46Z

There has been more than one month of inactivity. Shall we close this PR as someday?

* Redesigns .travis.yml to use the new container-based infrastructure. This lowers the waiting time for the queue, gives us the ability to use caches for apt and pip and improves testing time down to ~15min. We are not allowed too use `sudo` any more but we should need it, because Apache is not tested anyway. Signed-off-by: Marco Neumann <marco@crepererum.net>

dset0x · 2015-07-20T08:01:04Z

@jirikuncar I understand that this functionality will be moved to the demosite, as I see we no longer want it to be tested in invenio itself (#3371). If you prefer this to be closed for organizational reasons until/if it works, feel free.

jirikuncar · 2015-07-20T08:11:11Z

@dset0x the functionality of generating Apache configuration stays in Invenio. It's just hard to review your changes as the codebase is evolving a lot and you are not updating this PR.

dset0x · 2015-07-20T08:17:58Z

@jirikuncar This PR is not awaiting review - it is not working: There is commentary about the issues above.

invenio-developers added the Status: in work label Jan 6, 2015

tiborsimko added the Branch: master label Jan 6, 2015

tiborsimko assigned dset0x Jan 6, 2015

tiborsimko added this to the v2.0.x milestone Jan 6, 2015

dset0x force-pushed the apache-config branch 6 times, most recently from 6dbf552 to aaeabfa Compare January 12, 2015 11:42

jirikuncar reviewed Jan 12, 2015
View reviewed changes

dset0x force-pushed the apache-config branch 5 times, most recently from a101558 to aebe9c9 Compare January 19, 2015 09:42

jirikuncar reviewed Feb 20, 2015
View reviewed changes

jirikuncar added Service: INSPIRE Service: CDS Service: ZENODO labels Feb 20, 2015

dset0x reviewed Feb 20, 2015
View reviewed changes

dset0x force-pushed the apache-config branch from aebe9c9 to 4994955 Compare February 23, 2015 09:33

Dimitrios Semitsoglou-Tsiapos added 7 commits June 5, 2015 18:29

A paper label, with the words `SQUASH ME' beautifully printed on it in

cbae6b5

large letters

meeting time!

d293fec

NameVirtualHost should define a port

442b30b

revert apache log path to legacy

576a473

print apache logs on failure

13b5a2b

new docstring, drop dead cfg var

ae919a4

no dash at end of log name

31c1c0e

dset0x force-pushed the apache-config branch from 59a38b5 to a416ed0 Compare June 5, 2015 16:35

dset0x force-pushed the apache-config branch from a416ed0 to f3f7c20 Compare June 19, 2015 14:25

Dimitrios Semitsoglou-Tsiapos added 3 commits July 17, 2015 15:49

force WSGIPythonPath

571d098

s/wsgi_process/wsgi.process/g

c8d96dc

expand python path, correct python home

3f69daa

dset0x force-pushed the apache-config branch 7 times, most recently from bf632eb to 2f3c595 Compare July 17, 2015 14:53

dset0x force-pushed the apache-config branch from 2f3c595 to 0ea20cf Compare July 17, 2015 15:38

jirikuncar closed this Jul 20, 2015

jirikuncar added the Status: someday label Jul 20, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP base: rewrite apache configuration generator #2645

WIP base: rewrite apache configuration generator #2645

dset0x commented Jan 6, 2015

jirikuncar Jan 12, 2015

dset0x Jan 12, 2015

jirikuncar Jan 12, 2015

dset0x Jan 12, 2015

jirikuncar Jan 12, 2015

jirikuncar commented Jan 12, 2015

jirikuncar Feb 20, 2015

jirikuncar commented Feb 20, 2015

jirikuncar commented Feb 20, 2015

dset0x commented Feb 20, 2015

jirikuncar commented Feb 20, 2015

dset0x Feb 20, 2015

dset0x commented Jun 5, 2015

kaplun commented Jun 5, 2015

dset0x commented Jun 5, 2015

jirikuncar commented Jul 16, 2015

dset0x commented Jul 20, 2015

jirikuncar commented Jul 20, 2015

dset0x commented Jul 20, 2015

WIP base: rewrite apache configuration generator #2645

WIP base: rewrite apache configuration generator #2645

Conversation

dset0x commented Jan 6, 2015

jirikuncar Jan 12, 2015

Choose a reason for hiding this comment

dset0x Jan 12, 2015

Choose a reason for hiding this comment

jirikuncar Jan 12, 2015

Choose a reason for hiding this comment

dset0x Jan 12, 2015

Choose a reason for hiding this comment

jirikuncar Jan 12, 2015

Choose a reason for hiding this comment

jirikuncar commented Jan 12, 2015

jirikuncar Feb 20, 2015

Choose a reason for hiding this comment

jirikuncar commented Feb 20, 2015

jirikuncar commented Feb 20, 2015

dset0x commented Feb 20, 2015

jirikuncar commented Feb 20, 2015

dset0x Feb 20, 2015

Choose a reason for hiding this comment

dset0x commented Jun 5, 2015

kaplun commented Jun 5, 2015

dset0x commented Jun 5, 2015

jirikuncar commented Jul 16, 2015

dset0x commented Jul 20, 2015

jirikuncar commented Jul 20, 2015

dset0x commented Jul 20, 2015