access: usedeposit action addition #2906

jstypka · 2015-03-20T09:04:10Z

NEW Adds usedeposit action which enables per user access
restrictions for different deposit types. (closes RFC deposit: filter depositions based on user roles #2724)
Requires running webaccessadmin -u admin -c -a -D command.

Signed-off-by: Jan Stypka jan.stypka@cern.ch

jirikuncar · 2015-03-20T09:20:51Z

invenio/modules/access/local_config.py

@@ -558,7 +558,8 @@
               ('claimpaper_change_others_data', 'Change data of any person ID', '', 'no'),
               ('runbibtasklet', 'run BibTaskLet', '', 'no'),
               ('cfgbibsched', 'configure BibSched', '', 'no'),
-               ('runinfomanager', 'run Info Space Manager', '', 'no')
+               ('runinfomanager', 'run Info Space Manager', '', 'no'),
+               ('usedeposit', 'use deposit type', 'type', 'yes'),


this line is not needed if you define your own action in https://github.com/inveniosoftware/invenio/pull/2906/files#diff-1917d7fa51639dedef09e17079a8a7cdR25

jirikuncar · 2015-03-20T09:30:57Z

invenio/modules/deposit/views/deposit.py

@@ -236,6 +246,10 @@ def save(deposition_type=None, uuid=None, draft_id=None):

    deposition = Deposition.get(uuid, current_user, type=deposition_type)

+    dep_type = deposition_type if deposition_type else Deposition.get_type(uuid)


def deposition_type_from_request(): """Return deposition from parsed view arguments.""" return request.view_args.get( 'deposition_type', None ) or ( Deposition.get_type(request.view_args.get('uuid')) if request.view_args.get('uuid', None) else None )

jirikuncar · 2015-03-20T09:33:14Z

@jstypka can I ask you to first improve PEP8/PEP257 code style of the files you are going to edit? Thank you in advance

jstypka · 2015-03-20T12:01:20Z

@jirikuncar I've improved style of my code and the files in general. Hope that helps.

jirikuncar · 2015-03-20T12:31:13Z

@jstypka I think you might want to create new role and authorization similar to:

jstypka · 2015-03-20T12:41:32Z

@jirikuncar I can add it, but shouldn't the roles be specific for a particular Invenio instance?
E.g.
('articledeposituser', 'usedeposit', {'type' : 'article'}),
would imply that there should be an article deposition type, which is not always the case.

jirikuncar · 2015-03-20T12:43:47Z

Just use this: ('deposituser', 'usedeposit', {}), for Invenio and you can modify it in INSPIRE overlay similarly to https://github.com/inveniosoftware/invenio-demosite/blob/master/invenio_demosite/modules/access/config.py.

jstypka · 2015-03-20T14:12:26Z

@jirikuncar There you go!

jirikuncar · 2015-03-20T14:21:03Z

@jstypka it's shaping well. There is one last not addressed point in #2724 (comment).

jirikuncar · 2015-03-20T14:24:28Z

invenio/modules/deposit/models.py

@@ -521,8 +553,29 @@ def __unicode__(self):
        """ Return a name for this class """
        return self.get_identifier()

+    @classmethod
+    def all_authorized(cls, current_user):


def all_authorized(cls, user_info=None): user_info = user_info or current_user ...

jstypka · 2015-03-26T13:23:31Z

@jirikuncar I finally decided to go with your initial suggestion for the dict creation. The problem is that the acc_find_possible_actions_user function returns an empty list for the SUPERADMIN role, which would complicate the situation.

I also made an attempt to implement the cache - please have a look at it, because I'm not sure about some stuff.

jirikuncar · 2015-03-26T14:12:32Z

invenio/modules/deposit/cache.py

+    for collection, auth in zip(deposit_type_cacher.cache, auths):
+        if auth[0] == 0:
+            ret.append(collection)
+    return ret


Can you keep the new line character here(\n) (not new empty line \n\n or none \0). Thanks

jstypka · 2015-03-30T15:47:00Z

@jirikuncar so how does it look? Any other remarks?

jirikuncar · 2015-03-31T16:33:16Z

Can you also mention in commit message that one need to run: webaccessadmin -u admin -c -a -D.

cc @kaplun can you confirm that the command arguments work well? Thanks

jstypka · 2015-04-07T07:53:21Z

@jirikuncar done, is it good to go?

jirikuncar · 2015-04-07T08:03:45Z

@jstypka have you talked with @kaplun about the webaccessadmin? I'm not sure about the arguments. Otherwise it looks ok.

PS: Please keep the PR rebased on top of latest master. Thanks

kaplun · 2015-04-07T08:49:19Z

@jstypka, @jirikuncar, indeed it's correct. We can skip the -D since this is for the demosite and there are no demo authorization added in @jstypka's PR.

jirikuncar · 2015-04-07T09:59:57Z

@kaplun thanks! Please consider adding yourself there as reviewer. @jstypka please rebase the PR.

jirikuncar · 2015-04-07T15:13:15Z

ping @jstypka (#2906 (comment))

jstypka · 2015-04-07T15:22:48Z

@jirikuncar after resolving rebase conflicts I'm testing the application again. Please have a look at:
#2906 (comment)
I think there might be a bug in the batch_args usage.

jirikuncar · 2015-04-08T09:51:25Z

invenio/modules/deposit/cache.py

+        user_info,
+        'usedeposit',
+        batch_args=True,
+        type=deposit_type_cacher.cache


type=list(deposit_type_cacher.cache)

jirikuncar · 2015-04-08T12:22:32Z

@jstypka please note that there is a failing test

======================================================================
FAIL: test_registration (invenio.modules.deposit.testsuite.test_type_simplerecord.SimpleRecordTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/inveniosoftware/invenio/invenio/modules/deposit/testsuite/test_type_simplerecord.py", line 102, in test_registration
    assert "Tests" in res.data
AssertionError

----------------------------------------------------------------------

jirikuncar · 2015-04-08T12:25:26Z

@jstypka you have also left out (addresses #2724) or (closes #2724) in commit message.

jstypka · 2015-04-09T15:29:48Z

@jirikuncar I think I pushed all the changes that we discussed. Is it fine?

jirikuncar · 2015-04-09T15:54:20Z

@jstypka the tests are still failing 😞

jirikuncar · 2015-04-10T12:00:08Z

@jstypka do you need any help with the failing test? Please let us know if you are working on it. Thanks

jstypka · 2015-04-10T12:04:34Z

@jirikuncar Yes, I am currently trying to figure out why it fails. If I get stuck I'll let you know.

jirikuncar · 2015-04-14T07:27:40Z

@jstypka I offered my help so please tell me where is the problem or deliver working solution. Thank you!

jstypka · 2015-04-14T08:27:17Z

@jirikuncar I sent you an e-mail few days ago. Basically the cache at the beginning seems to be filled properly, however the UserInfo object that is checked during the test seems to be a blank one - all lists empty, all fields False etc.

jirikuncar · 2015-04-23T11:44:22Z

@jstypka please use my updated commit from https://github.com/jirikuncar/invenio/tree/2906-fix. Moreover we need to protect also deposit REST API - most importantly https://github.com/inveniosoftware/invenio/blob/master/invenio/modules/deposit/restful.py#L250.

* NEW Adds usedeposit action which enables per user access restrictions for different deposit types (closes inveniosoftware#2724). * Requires running `webaccessadmin -u admin -c -a -D` command. Signed-off-by: Jan Stypka <jan.stypka@cern.ch>

jirikuncar · 2015-05-26T20:14:39Z

Is anybody looking into this? (cc @kaplun @jmartinm @jalavik)

jirikuncar · 2015-05-28T11:06:50Z

I have fixed the issue with tests (see https://github.com/jirikuncar/invenio/tree/2906-fix) caused by caches in user info object.

@jstypka add permission checking to REST API.

cc @kaplun @jmartinm @jalavik @tiborsimko

jirikuncar · 2015-05-29T08:29:41Z

Superseded by #3172

invenio-developers added the Status: in review label Mar 20, 2015

jirikuncar reviewed Mar 20, 2015
View reviewed changes

jstypka force-pushed the rfc-2724 branch from a600f81 to 6a696e7 Compare March 20, 2015 09:28

jirikuncar reviewed Mar 20, 2015
View reviewed changes

jirikuncar added this to the v2.1 milestone Mar 20, 2015

jirikuncar assigned jstypka Mar 20, 2015

jirikuncar added the Type: enhancement label Mar 20, 2015

jstypka force-pushed the rfc-2724 branch from 6a696e7 to 9046bb6 Compare March 20, 2015 10:11

jstypka force-pushed the rfc-2724 branch 2 times, most recently from 4de138b to e38ac49 Compare March 20, 2015 12:50

jirikuncar reviewed Mar 20, 2015
View reviewed changes

jstypka force-pushed the rfc-2724 branch 3 times, most recently from f8c21b5 to 3c8e030 Compare March 26, 2015 13:20

jirikuncar reviewed Mar 26, 2015
View reviewed changes

jstypka force-pushed the rfc-2724 branch 2 times, most recently from 029e9d7 to e881964 Compare March 26, 2015 14:50

jstypka force-pushed the rfc-2724 branch from e881964 to 42a1911 Compare March 31, 2015 14:55

jstypka force-pushed the rfc-2724 branch from 42a1911 to 8b652b9 Compare March 31, 2015 16:38

jirikuncar reviewed Apr 8, 2015
View reviewed changes

jstypka force-pushed the rfc-2724 branch from 8b652b9 to f89bee4 Compare April 8, 2015 11:25

jstypka force-pushed the rfc-2724 branch 2 times, most recently from 28ccf4b to 87b26d2 Compare April 8, 2015 15:43

access: usedeposit action addition

5aae94d

* NEW Adds usedeposit action which enables per user access restrictions for different deposit types (closes inveniosoftware#2724). * Requires running `webaccessadmin -u admin -c -a -D` command. Signed-off-by: Jan Stypka <jan.stypka@cern.ch>

jstypka force-pushed the rfc-2724 branch from 87b26d2 to 5aae94d Compare April 27, 2015 14:33

jirikuncar closed this May 29, 2015

jirikuncar unassigned jstypka Jul 25, 2016

jirikuncar removed the Status: in review label Jul 25, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

access: usedeposit action addition #2906

access: usedeposit action addition #2906

jstypka commented Mar 20, 2015

jirikuncar Mar 20, 2015

jirikuncar Mar 20, 2015

jirikuncar commented Mar 20, 2015

jstypka commented Mar 20, 2015

jirikuncar commented Mar 20, 2015

jstypka commented Mar 20, 2015

jirikuncar commented Mar 20, 2015

jstypka commented Mar 20, 2015

jirikuncar commented Mar 20, 2015

jirikuncar Mar 20, 2015

jstypka commented Mar 26, 2015

jirikuncar Mar 26, 2015

jstypka commented Mar 30, 2015

jirikuncar commented Mar 31, 2015

jstypka commented Apr 7, 2015

jirikuncar commented Apr 7, 2015

kaplun commented Apr 7, 2015

jirikuncar commented Apr 7, 2015

jirikuncar commented Apr 7, 2015

jstypka commented Apr 7, 2015

jirikuncar Apr 8, 2015

jirikuncar commented Apr 8, 2015

jirikuncar commented Apr 8, 2015

jstypka commented Apr 9, 2015

jirikuncar commented Apr 9, 2015

jirikuncar commented Apr 10, 2015

jstypka commented Apr 10, 2015

jirikuncar commented Apr 14, 2015

jstypka commented Apr 14, 2015

jirikuncar commented Apr 23, 2015

jirikuncar commented May 26, 2015

jirikuncar commented May 28, 2015

jirikuncar commented May 29, 2015

		@@ -236,6 +246,10 @@ def save(deposition_type=None, uuid=None, draft_id=None):

		deposition = Deposition.get(uuid, current_user, type=deposition_type)

		dep_type = deposition_type if deposition_type else Deposition.get_type(uuid)

access: usedeposit action addition #2906

access: usedeposit action addition #2906

Conversation

jstypka commented Mar 20, 2015

jirikuncar Mar 20, 2015

Choose a reason for hiding this comment

jirikuncar Mar 20, 2015

Choose a reason for hiding this comment

jirikuncar commented Mar 20, 2015

jstypka commented Mar 20, 2015

jirikuncar commented Mar 20, 2015

jstypka commented Mar 20, 2015

jirikuncar commented Mar 20, 2015

jstypka commented Mar 20, 2015

jirikuncar commented Mar 20, 2015

jirikuncar Mar 20, 2015

Choose a reason for hiding this comment

jstypka commented Mar 26, 2015

jirikuncar Mar 26, 2015

Choose a reason for hiding this comment

jstypka commented Mar 30, 2015

jirikuncar commented Mar 31, 2015

jstypka commented Apr 7, 2015

jirikuncar commented Apr 7, 2015

kaplun commented Apr 7, 2015

jirikuncar commented Apr 7, 2015

jirikuncar commented Apr 7, 2015

jstypka commented Apr 7, 2015

jirikuncar Apr 8, 2015

Choose a reason for hiding this comment

jirikuncar commented Apr 8, 2015

jirikuncar commented Apr 8, 2015

jstypka commented Apr 9, 2015

jirikuncar commented Apr 9, 2015

jirikuncar commented Apr 10, 2015

jstypka commented Apr 10, 2015

jirikuncar commented Apr 14, 2015

jstypka commented Apr 14, 2015

jirikuncar commented Apr 23, 2015

jirikuncar commented May 26, 2015

jirikuncar commented May 28, 2015

jirikuncar commented May 29, 2015