Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolanguage Test #15

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Isolanguage Test #15

merged 1 commit into from
Oct 19, 2020

Conversation

cenouralm
Copy link
Contributor

No description provided.

@cenouralm cenouralm force-pushed the isolanguage branch 3 times, most recently from 9c1a7e5 to 192a628 Compare October 2, 2020 13:43
@cenouralm cenouralm marked this pull request as ready for review October 5, 2020 08:49
@lnielsen lnielsen added this to In progress in InvenioRDM October Board Oct 13, 2020
@cenouralm cenouralm moved this from In progress to In Review in InvenioRDM October Board Oct 13, 2020
ppanero
ppanero reviewed Oct 14, 2020
View reviewed changes
tests/test_isolanguage.py Outdated Show resolved Hide resolved
fenekku
fenekku approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. Ready when addressed.

tests/test_isolanguage.py Outdated Show resolved Hide resolved
tests/test_isolanguage.py Outdated Show resolved Hide resolved
tests/test_isolanguage.py Outdated Show resolved Hide resolved
@ppanero ppanero moved this from In Review to In progress in InvenioRDM October Board Oct 14, 2020
@cenouralm cenouralm moved this from In progress to In Review in InvenioRDM October Board Oct 19, 2020
ppanero
ppanero approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@ppanero ppanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, maybe use more explicit names like lang instead of placeholders like f or i... but LGTM.

@lnielsen lnielsen merged commit e41bacc into inveniosoftware:master Oct 19, 2020
InvenioRDM October Board automation moved this from In Review to Done Oct 19, 2020
@cenouralm
Copy link
Contributor Author

A small bug was found on this PR and I fixed it on #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppanero ppanero ppanero approved these changes

@fenekku fenekku Awaiting requested review from fenekku

Assignees

@cenouralm cenouralm

Labels
None yet
Projects
No open projects
InvenioRDM October Board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cenouralm @fenekku @ppanero @lnielsen