Don’t generate invalid closing </link> tags #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are forbidden in HTML 4 and HTML5. https://www.w3.org/TR/html401/struct/links.html#edef-LINK https://www.w3.org/TR/html5/document-metadata.html#the-link-element Use self-closing syntax for XHTML compatibility. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
Thanks for the PR! I'll prepare a new release. |
|
For the copyright header, could you please clarify if you personally or MIT are the copyright holder of your contribution (i.e. at CERN all employees sign employment contract that grants all IP to CERN)? |
|
To whatever extent there's anything copyrightable in my contribution, it belongs to me personally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are forbidden in HTML 4 and HTML5.
https://www.w3.org/TR/html401/struct/links.html#edef-LINK
https://www.w3.org/TR/html5/document-metadata.html#the-link-element
Use self-closing syntax for XHTML compatibility.