frontsite: DocumentDetails: Display multipart above Literature Title #624
Conversation
| render() { | ||
| const { metadata } = this.props; | ||
| const volume = _get(metadata, 'relations.multipart_monograph[0].volume'); | ||
|
|
||
| return ( | ||
| <> | ||
| <Header> |
There was a problem hiding this comment.
if you don't check if the volume number and relation metadata exists before rendering the Header component, you will most likely end up with an empty space on top of the column (for regular books without multipart and serials)
| <Link key={rel.pid_value} to={this.getLinkTo(rel)}> | ||
| {rel.record_metadata.title} | ||
| </Link> | ||
| {index === relationsData.length - 1 ? ' featuring:' : ' and '} |
There was a problem hiding this comment.
not sure I understand why we need "and"?
There was a problem hiding this comment.
Because it is a list, there can be multiple relations, can also use ,
There was a problem hiding this comment.
normally, a volume can belong only to one multipart monograph (but multiple serials, that's why it is modelled as a list), but for this particular case we should display only one multipart
|
The PR looks good, but I have some doubts on the UX/design of the |
❤️ Thank you for your contribution!
Description
closes: CERNDocumentServer/cds-ils#734